RFR: 8374808: Add new methods to KeyStore and KeyStoreSpi that return the creation date as an Instant instead of Date [v8]
Mikhail Yankelevich
myankelevich at openjdk.org
Thu Feb 5 19:30:44 UTC 2026
On Thu, 5 Feb 2026 19:01:50 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>>
>> patter matching comment
>
> src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java line 640:
>
>> 638: dos.writeLong(
>> 639: ((TrustedCertEntry)entry).date.toEpochMilli()
>> 640: );
>
> Not very common to write `);` on a new line.
>
> Same below on line 659. Also in `JavaKeyStore` line 633.
I'd personally prefer to keep it this way as when it was inline it was really hard to read for me. If you feel strongly about it - I can change it :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2770789150
More information about the security-dev
mailing list