RFR: 8374001: sun/security/ skip without Exceptions [v2]

Matthew Donovan mdonovan at openjdk.org
Thu Jan 22 12:45:43 UTC 2026


On Wed, 7 Jan 2026 11:22:54 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Pr cleaning up the tests left after the previous PRs.
>> 
>> * test/jdk/sun/security/util/Resources/Usages.java
>> * test/jdk/sun/security/ssl/CertPathRestrictions/TLSRestrictions.java
>> * test/jdk/sun/security/krb5/config/ConfPlusProp.java
>> * test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java
>
> Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - updating to latest master and copyrights
>  - Merge branch 'master' into JDK-8374001
>  - JDK-8374001: sun/security/ skip without Exceptions

LGTM, one minor suggestion. You can take it or leave it.

test/jdk/sun/security/krb5/config/ConfPlusProp.java line 44:

> 42:                 System.getenv("LOGONSERVER") != null) {
> 43:             throw new SkippedException(
> 44:                     "Looks like a Windows machine in a domain.");

maybe change the message to "Test cannot run in a domain."?

-------------

PR Review: https://git.openjdk.org/jdk/pull/28898#pullrequestreview-3692262362
PR Review Comment: https://git.openjdk.org/jdk/pull/28898#discussion_r2716752770


More information about the security-dev mailing list