RFR: 8374001: sun/security/ skip without Exceptions [v2]

Mikhail Yankelevich myankelevich at openjdk.org
Mon Jan 26 12:07:59 UTC 2026


On Thu, 22 Jan 2026 12:41:31 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - updating to latest master and copyrights
>>  - Merge branch 'master' into JDK-8374001
>>  - JDK-8374001: sun/security/ skip without Exceptions
>
> test/jdk/sun/security/krb5/config/ConfPlusProp.java line 44:
> 
>> 42:                 System.getenv("LOGONSERVER") != null) {
>> 43:             throw new SkippedException(
>> 44:                     "Looks like a Windows machine in a domain.");
> 
> maybe change the message to "Test cannot run in a domain."?

Yes, I believe this sounds better, thanks. Updated in the next commit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28898#discussion_r2727348620


More information about the security-dev mailing list