RFR: JDK-8218128: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003 and 004 use wrong path to test classes
Chris Plummer
chris.plummer at oracle.com
Thu Mar 7 21:02:32 UTC 2019
Hi Gary,
Why did you remove the "nonconcurrent" keyword. I know these are just
comments for reference that were added when the test was ported from
tonga, but as a comment it is still applicable. The test should not be
run concurrent with others (which you have also fixed with the addition
of the "exclusiveAccess.dirs=.").
Otherwise changes look good.
thanks,
Chris
On 3/7/19 10:57 AM, Gary Adams wrote:
> This proposed fix will restore the ResourceExhausted tests.
>
> Test 3 and 4 were on the ProblemList because of the potential
> path issues in finding the correct classes. This change searches the
> test.class.path for the appropriate vmTestbase classes rather than using
> incorrect settings on the command line.
>
> Some clean up has been done to remove quarantine keyword
> and @ignore directives. Should additional clean up be done to remove
> bug numbers, etc.?
>
> TEST.PROPERTIES were added so test 3 so it is consistent with the
> other tests
> in the group.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8218128
> Webrev: http://cr.openjdk.java.net/~gadams/8218128/webrev.00/index.html
>
> Local testing has been successful on a linux-x64-debug build.
> Testing on mach5 for other platforms next.
More information about the serviceability-dev
mailing list