RFR: 8236736: Change notproduct JVM flags to develop flags [v2]

[Ioi Lam]

On Tue, 2 Apr 2024 16:21:15 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Remove the notproduct distinction for command line options, rather than trying to wrestle the macros to fix the bug that they've been treated as develop options for some time now.  This simplifies the command line option macros.
>> 
>> Tested with tier1-4, tier1 on Oracle platforms.  Also built shenandoah.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Clean up notproduct from tests.

LGTM

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18541#pullrequestreview-1974322553