RFR: 8236736: Change notproduct JVM flags to develop flags [v2]

[Stefan Karlsson]

On Tue, 2 Apr 2024 16:24:19 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Remove the notproduct distinction for command line options, rather than trying to wrestle the macros to fix the bug that they've been treated as develop options for some time now.  This simplifies the command line option macros.
>> 
>> Tested with tier1-4, tier1 on Oracle platforms.  Also built shenandoah.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Clean up notproduct from tests.

src/hotspot/share/runtime/arguments.cpp line 3420:

> 3418: static void apply_debugger_ergo() {
> 3419: #ifndef PRODUCT
> 3420:   // UseDebuggerErgo is notproduct

Now that the flag has been changed to a develop flag, it seems wrong that these are guarded by "#ifndef PRODUCT". Shouldn't this be changed to check for ASSERT instead?

src/hotspot/share/runtime/flags/jvmFlag.hpp line 118:

> 116:     EXPERIMENTAL_FLAG_BUT_LOCKED,
> 117:     DEVELOPER_FLAG_BUT_PRODUCT_BUILD,
> 118:     NOTPRODUCT_FLAG_BUT_PRODUCT_BUILD

Should the ',' on the previous line be removed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18541#discussion_r1548236362
PR Review Comment: https://git.openjdk.org/jdk/pull/18541#discussion_r1548239130