RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

[Vladimir Kozlov]

On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Remove the notproduct distinction for command line options, rather than trying to wrestle the macros to fix the bug that they've been treated as develop options for some time now.  This simplifies the command line option macros.
>> 
>> Tested with tier1-4, tier1 on Oracle platforms.  Also built shenandoah.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix a couple issues pointed out by Stefank.

So you finally decided to take on [JDK-8183288](https://bugs.openjdk.org/browse/JDK-8183288)

Essentially you are removing "optimized" VM build with these changes. In this case you need to change make files.

All Statistics flags should be product (which will increase product VM size) - it is important. May be need build's variable `--enable-jvm-feature-statistcs` to include statistics code on demand.

-------------

Changes requested by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18541#pullrequestreview-1974500625