RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

[Coleen Phillimore]

On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Remove the notproduct distinction for command line options, rather than trying to wrestle the macros to fix the bug that they've been treated as develop options for some time now.  This simplifies the command line option macros.
>> 
>> Tested with tier1-4, tier1 on Oracle platforms.  Also built shenandoah.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix a couple issues pointed out by Stefank.

The optimized build still works as before (actually surprised it still builds). Since for a long time the notproduct options acted like develop options, they still do just the same for the optimized build.

For optimized, all the develop and notproduct options are materialized.   Now just develop, not distinguishing notproduct from that.  The same code enabled in PRODUCT is still enabled.  I haven't looked at that removing optimized bug in a while.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18541#issuecomment-2032704606