RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

[Coleen Phillimore]

On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Remove the notproduct distinction for command line options, rather than trying to wrestle the macros to fix the bug that they've been treated as develop options for some time now.  This simplifies the command line option macros.
>> 
>> Tested with tier1-4, tier1 on Oracle platforms.  Also built shenandoah.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix a couple issues pointed out by Stefank.

Yes, I had to remember what optimized did.  It gets all the options, but builds with optimization and doesn't turn on asserts.  I only removed the notproduct flag distinction since it hasn't been distinct for years and it's confusing what we actually wanted it to do.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18541#issuecomment-2032794955