RFR: 8236736: Change notproduct JVM flags to develop flags [v3]

[Vladimir Kozlov]

On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Remove the notproduct distinction for command line options, rather than trying to wrestle the macros to fix the bug that they've been treated as develop options for some time now.  This simplifies the command line option macros.
>> 
>> Tested with tier1-4, tier1 on Oracle platforms.  Also built shenandoah.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix a couple issues pointed out by Stefank.

Long ago, before [JDK-8024545](https://bugs.openjdk.org/browse/JDK-8024545) we did not have not_product flags declared in product build. Only debug flags were declared as constant. We relied on that change since then.
That is why you may see the issue with not materialized flags in product build.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18541#issuecomment-2032835463