RFR: Cleanups, TODOs, asserts (part 2)

Aleksey Shipilev shade at openjdk.org
Wed Apr 12 09:11:26 UTC 2023


On Tue, 11 Apr 2023 17:40:54 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> I have been reading the openjdk/shenandoah vs openjdk/jdk diff and these are the simple code massages we can do to improve and bullet-proof the code, hopefully without changing the semantics. This would continue with more parts later.
>> 
>> Additional testing:
>>  - [x] macos-aarch64-server-fastdebug (some pre-existing failures)
>>  - [x] GHA builds
>
> src/hotspot/share/gc/shenandoah/shenandoahMemoryPool.hpp line 40:
> 
>> 38: 
>> 39: public:
>> 40:   // TODO: Have a separate memory pool implementation for non-generational
> 
> Not sure about this.

All right, I reverted that part. I'll try to deal with this separately.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/252#discussion_r1163845654


More information about the shenandoah-dev mailing list