RFR: 245: Fix proxy protocol setting, add logging

Erik Helin ehelin at openjdk.java.net
Fri Jan 24 13:42:00 UTC 2020

On Fri, 24 Jan 2020 12:14:42 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> Please review this follow-up change that fixes the proxy type selection, and also adds some logging. In addition, if proxy settings are picked up from the environment, nonProxyHosts are now always set. This avoids a problem when nonProxyHosts has a default value.
> Best regards,
> Robin

Looks good, thanks Robin for fixing this! Just a very minor nit about adding a comment.

proxy/src/main/java/org/openjdk/skara/proxy/HttpProxy.java line 60:

> 59:                 if (!output.startsWith("http://") && !output.startsWith("https://")) {
> 60:                     output = "http://" + output;
> 61:                 }

Add a comment that the protocol being prepended doesn't matter?


Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/382

More information about the skara-dev mailing list