RFR: 245: Fix proxy protocol setting, add logging

[Robin Westberg]

On Fri, 24 Jan 2020 13:28:13 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this follow-up change that fixes the proxy type selection, and also adds some logging. In addition, if proxy settings are picked up from the environment, nonProxyHosts are now always set. This avoids a problem when nonProxyHosts has a default value.
>> 
>> Best regards,
>> Robin
> 
> proxy/src/main/java/org/openjdk/skara/proxy/HttpProxy.java line 60:
> 
>> 59:                 if (!output.startsWith("http://") && !output.startsWith("https://")) {
>> 60:                     output = "http://" + output;
>> 61:                 }
> 
> Add a comment that the protocol being prepended doesn't matter?

Sure, sounds reasonable.

-------------

PR: https://git.openjdk.java.net/skara/pull/382