RFR: 282: Make the review requirements more explicit in the progress list [v3]
Guoxiong Li
gli at openjdk.java.net
Wed May 11 12:43:22 UTC 2022
On Wed, 11 May 2022 12:28:43 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Fixed.
>
> @lgxbslgx I missed reviewing this when it was open, and am just going through the backlog of changes that has happened now.
>
> However, I think this was incorrect. The code here makes the text appears as:
>
> Change must be properly reviewed (1 review required, with at least 1 reviewer)
>
>
> when it should have been:
>
> Change must be properly reviewed (1 review required, with at least 1 Reviewer)
>
>
> (Note the capitalization of Reviewer).
>
> Traditionally, the (not very clear, I admit) distinction has been made in OpenJDK between "reviewer" (anyone who offers a review) and a "Reviewer" (a member with the official status as Reviewer for a project). This text is about the latter, so changing the "r" to a "R" in the message made a significant difference.
>
> Can you please fix this in a follow-up PR?
Do the `contributor`, `author`, `committer`, `lead` also need to be changed to `Contributor`, `Author`, `Committer`, `Lead`?
-------------
PR: https://git.openjdk.java.net/skara/pull/1305
More information about the skara-dev
mailing list