RFR: 1437: Fix the OpenJDK official role name and pluralization [v2]

Magnus Ihse Bursie ihse at openjdk.java.net
Thu May 12 08:49:50 UTC 2022


On Thu, 12 May 2022 03:38:44 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch mainly fixes the following message:
>> 
>> 1. Remove the pluralization if these is 0 reviewer. `no reviews required` --> `no review required`
>> 2. Fix the official role name. eg: `reviewer` --> `Reviewer`, `committers` --> `Committers`
>> 3. Unify the comment and the progress message. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)`
>> 4. Fix the pluralization of the comment. ` (with 1 of role reviewers)` --> `(with at least 1 Reviewer)` Note the pluralization.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add bylaws link of the role.

Marked as reviewed by ihse (Reviewer).

Looks great! Thanks for doing this.

-------------

PR: https://git.openjdk.java.net/skara/pull/1319


More information about the skara-dev mailing list