RFR: 1999: Only post ApprovalNeededComment after pr is otherwise ready for integration [v2]

Erik Joelsson erikj at openjdk.org
Mon Aug 21 21:45:01 UTC 2023

On Mon, 21 Aug 2023 20:29:37 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In [SKARA-1199](https://bugs.openjdk.org/browse/SKARA-1199), I made a bug about posting approvalNeededComment. 
>> Before the bot posting ApprovalNeededComment, we need to make sure this pr could pass all the checks.
>> This PR also solves an issue in /approve command. If the command issuer is not an integrator, then the bot should return immediately.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   fix another problem

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1335:

> 1333:             }
> 1334: 
> 1335:             if (approvalNeeded() && visitor.messages().isEmpty()) {

Is this enough? Shouldn't we check `readyForReview` as well. What about the other things in the list for `readyForIntegration`?


PR Review Comment: https://git.openjdk.org/skara/pull/1546#discussion_r1300677904

More information about the skara-dev mailing list