RFR: 1999: Only post ApprovalNeededComment after pr is otherwise ready for integration [v2]

[Zhao Song]

On Mon, 21 Aug 2023 22:20:00 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1335:
>> 
>>> 1333:             }
>>> 1334: 
>>> 1335:             if (approvalNeeded() && visitor.messages().isEmpty()) {
>> 
>> Is this enough? Shouldn't we check `readyForReview` as well. What about the other things in the list for `readyForIntegration`?
>
> You are right. I will fix the problem soon. Thank you.

I also refactored the code about `readyForIntegration`.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1546#discussion_r1300740409