RFR: 1851: Fold CSR bot into PR bot

Zhao Song zsong at openjdk.org
Mon Mar 27 23:30:55 UTC 2023

On Mon, 27 Mar 2023 22:53:44 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> In this patch, the whole csr bot module is removed. 
>> Original CSRPullRequestBot is deleted. The functionality of this bot has been moved to `CheckRun`.
>> Original CSRIssueBot has been moved to pr bot module. PullRequestBotFactory would generate a CSRIssueBot for every configured Issue project.
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 63:
>> 61:     private final boolean forceUpdate;
>> 62: 
>> 63:     CheckWorkItem(PullRequestBot bot, String prId, Consumer<RuntimeException> errorHandler, ZonedDateTime prUpdatedAt,
> There are a lot of calls to the old constructor. Instead of adding `false` to all of them, perhaps overload the constructor with a default false.

Yes, it's a good idea


PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1149880270

More information about the skara-dev mailing list