RFR: 2286: Git jcheck --working-tree/--staged not compatible with some checks [v2]

[Erik Joelsson]

On Fri, 7 Jun 2024 18:08:55 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In [SKARA-1690](https://bugs.openjdk.org/browse/SKARA-1690), I tried to make SKARA CLI able to run jcheck on the diff in current working tree. But seems like this feature is not compatible with some jchecks like problemLists check.
>> 
>> When jcheck is checking staged or working-tree, I think there is no point to run some checks that require real commit message. Therefore I disabled the checks and Skara CLI will print a prompt to user.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 328:

> 326:             ranges.clear();
> 327:             ranges.add(STAGED_REV);
> 328:             System.out.println("When jcheck is running on staged, the following commit checks are available: " + JCheck.commitCheckNamesForStagedOrWorkingTree());

Suggestion:

            System.out.println("When jcheck is running on staged, only the following commit checks are available: " +
                    JCheck.commitCheckNamesForStagedOrWorkingTree());

cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java line 333:

> 331:             ranges.clear();
> 332:             ranges.add(WORKING_TREE_REV);
> 333:             System.out.println("When jcheck is running on working-tree, the following commit checks are available: " + JCheck.commitCheckNamesForStagedOrWorkingTree());

Suggestion:

            System.out.println("When jcheck is running on working-tree, only the following commit checks are available: " +
                    JCheck.commitCheckNamesForStagedOrWorkingTree());

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1658#discussion_r1631611335
PR Review Comment: https://git.openjdk.org/skara/pull/1658#discussion_r1631611676