RFR: 2213: Record reviewers with stale reviews in the commit message

[Zhao Song]

On Thu, 28 Mar 2024 12:51:52 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> As a user requested, when `ignoreStaleReview` is enabled in a repo, Skara bot should still record reviewers with stale reviews in the commit message.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckablePullRequest.java line 91:
> 
>> 89:                     }
>> 90:                 }
>> 91:                 reviewers.addAll(reviewerNames(staleReviews, namespace));
> 
> I think all of this could be replaced with just adding `manualReviewersAndStaleReviewers` to the filter condition at line 76.

But the review with non-existing commit(e.g. after a reviewer approved the pr, the author force pushed) or the review made when the pr targets a different branch will be filtered out.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1626#discussion_r1543298627