September 2014 - core-libs-dev

test paths in repo
by John Rose 05 Sep '14

05 Sep '14

David Chase and I just noticed files like this in the JDK: http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/test/java/util/stream/tes… The package for the test code is "org.openjdk.tests.java.util.stream". Although that's long, it is completely unambiguous. Generally, grammar of such paths appears to be: $REPO / test / $TEST_PACKAGE_PREFIX / $API_PACKAGE where TEST_PACKAGE_PREFIX is fixed as "org/openjdk/tests", and API_PACKAGE is "java/util/stream" or some such. Has this organization for tests worn well? Would you do it again that way? Also, What is the reason for the close correspondence between the file system pathname and the Java package declaration? Is it so that IDEs can easily find the test files? (If so, which IDEs?) For David's Arrays 2.0 work, which in some ways resembles the streams work, we want a good organization for tests, so we are looking at the streams tests as a template. Thanks for any insights... — John

3 2

RFR: 8049343: (tz) Support tzdata2014f
by Aleksej Efimov 04 Sep '14

04 Sep '14

Hi, Please, review the tzdata2014f integration (with tzdata2014e related changes included too) [1] fix to JDK9: http://cr.openjdk.java.net/~aefimov/8049343/9/webrev.01/ The tzdata2014f changes are extensive and relates mostly to timezone short names changes + "Asia/Srednekolymsk" time zone were added. Almost complete list of changes can be found in the JBS bug description [1], plus some changes wasn't documented in tzdata release notes - for such cases raw tzdata diff was used for the names modifications. Two issues with JSR310 implementation were discovered during integration process: First issue is related to the internal representation of the '24:00' value. The JSR310 implementation treats this value as a next day 00:00 time. The workaround already exists in JSR310 code for similar entries and this failure is resolved in similar way [2] as part of this update. For the second issue JDK-8051641 [3] was filled and 'sun/util/calendar/zi/TestZoneInfo310.java' test is the only one that fails with this tzdata. Other time zone related tests [4] passes without failures. Thank you, Aleksej [1] https://bugs.openjdk.java.net/browse/JDK-8049343 [2] http://cr.openjdk.java.net/~aefimov/8049343/9/webrev.01/src/java.base/share… [3] https://bugs.openjdk.java.net/browse/JDK-8051641 [4] TZ related test sets: test/sun/util/calendar test/java/util/Calendar test/sun/util/resources/TimeZone test/sun/util/calendar test/java/util/TimeZone test/java/time\ test/java/util/Formatter test/closed/java/util/Calendar test/closed/java/util/TimeZone

3 12

RFR: 8055776, Add tests to exercise SQLPermissions for DriverManager & SyncFactory
by Lance Andersen 03 Sep '14

03 Sep '14

Hi all, This is a request for review for This adds tests which exercise SQLPermissions for DriverManager and SyncFactory. The webrev can be found at http://cr.openjdk.java.net/~lancea/8055776/webrev.00/ Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com

2 3

ReferenceQueue.remove to allow GC of the queue itself
by Jaroslav Tulach 03 Sep '14

03 Sep '14

Hi. I'd like to add one new method into java.lang.ref.ReferenceQueue. Can anyone help me go through the review process? I've reported https://bugs.openjdk.java.net/browse/JDK-8051843 but that probably is not enough, right? Thanks in advance for your help. -jt

12 54

[9] RFR (S): 8056926: Improve caching of GuardWithTest combinator
by Vladimir Ivanov 01 Sep '14

01 Sep '14

http://cr.openjdk.java.net/~vlivanov/8056926/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8056926 Cache GuardWithTest per erased to basic types signature. GWT shape is made friendly to sharing: * GWT MH is implemented as BMH which stores 3 method handles * LF loads them from the associated MethodHandle Testing: jdk/java/lang/invoke, jdk/java/util/streams, nashorn, octane w/ "-ea -esa" and COMPILE_THRESHOLD={0,30}. Reviewed-by: vlivanov, ? Contributed-by: john.r.rose(a)oracle.com Thanks! Best regards, Vladimir Ivanov

2 4

Process API Updates (JEP 102)
by Ron Pressler 01 Sep '14

01 Sep '14

I might be a little late to this party, but recently I've had a (rather frustrating) need for the ability to execve a process rather than fork-exec it. I understand that the ability to exec (replace the current process's image) is also available on Windows. This operation (on ProcessBuilder?), which never returns, would have the same semantics as System.exit(pb.start().waitFor()), only it would replace the current JVM process (i.e. maintain the same pid/handle) with the command. This is required when a JVM process is used to set up and launch another, JVM or other, process, but we'd want the user running the program to be oblivious to the setup process (because, say, they want to monitor the running program with some OS tool). Ron

2 2

RFR 8056249 Improve CompletableFuture resource usage
by Paul Sandoz 01 Sep '14

01 Sep '14

Hi, Please review fixes by Doug to j.u.c.CompletableFuture to better control resources for long completion chains (e.g. avoiding stack overflows). This fix resulted in a lot of internal refactoring and clean up. There are also some doc clarifications for certain j.u.c.CompletationStage exception handling methods (which most likely means a CCC is required). https://bugs.openjdk.java.net/browse/JDK-8056249 http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8056249-cf-resource-usage/webr… -- Is the following snippet missing from the doc updates to the methods CompletationStage.handle and handleAsync? If the supplied function itself encounters an exception, then the returned stage exceptionally completes with this exception unless this stage also completed exceptionally. Paul.

4 7