September 2014 - core-libs-dev

Replace uses of StringBuffer with StringBuilder[JAXP]
by Otávio Gonçalves de Santana 12 Sep '14

12 Sep '14

Similar to: https://bugs.openjdk.java.net/browse/JDK-8041679 But in JAXP project: https://dl.dropboxusercontent.com/u/16109193/open_jdk/jax%E1%B9%95/string_b… -- Otávio Gonçalves de Santana blog: http://otaviosantana.blogspot.com.br/ twitter: http://twitter.com/otaviojava site: *http://about.me/otaviojava <http://about.me/otaviojava>* 55 (11) 98255-3513

3 11

[9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java
by Konstantin Shefov 12 Sep '14

12 Sep '14

Hello, Please review the change in testlibrary https://bugs.openjdk.java.net/browse/JDK-8057707 This change is needed for new tests for the feature "Lambda Form Reduction and Caching" https://bugs.openjdk.java.net/browse/JDK-8046703 Webrev of the testlibrary change: http://cr.openjdk.java.net/~kshefov/8057707/webrev.00/ JBS entry for new test dev is https://bugs.openjdk.java.net/browse/JDK-8057719 Webrev for new tests is http://cr.openjdk.java.net/~kshefov/8057719/webrev.00/ Thanks -Konstantin

4 6

[9] Review request : JDK-8057719: Develop new tests for LambdaForm Reduction and Caching feature
by Konstantin Shefov 12 Sep '14

12 Sep '14

Hello, Please review the new tests for the feature "Lambda Form Reduction and Caching" https://bugs.openjdk.java.net/browse/JDK-8046703 JBS task: https://bugs.openjdk.java.net/browse/JDK-8057719 Webrev: http://cr.openjdk.java.net/~kshefov/8057719/webrev.00/ These tests also depend on testlibrary change: https://bugs.openjdk.java.net/browse/JDK-8057707 Webrev of the testlib change: http://cr.openjdk.java.net/~kshefov/8057707/webrev.00/ Thanks -Konstantin

4 4

[9] RFR: JDK-8054548: JAX-WS tools need to updated to work with modular image
by Miroslav Kos 12 Sep '14

12 Sep '14

Hello, please review following change: JBS: https://bugs.openjdk.java.net/browse/JDK-8054548 webrev: http://cr.openjdk.java.net/~mkos/8054548/jaxws.00/ It is basically replacing obsolete code using core reflection by javax.tools API plus removing old unused code. I ran the unit tests against both standalone JAX-WS and jdk, no regressions occurred. Thanks Miran

2 5

RFR [8046339] sun.rmi.transport.DGCAckHandler leaks memory
by Ivan Gerasimov 12 Sep '14

12 Sep '14

Hello everyone! It has been reported that under some conditions instances of sun.rmi.transport.DGCAckHandler accumulate and can cause OOM Error. This is because they are stored in the global DGCAckHandler.idTable map, and may fail to be removed if a timeout has expired. The webrev contains a fix proposed by Darryl Mocek back in 2011. Unfortunately I couldn't come up with a regression test for the fix. However, the fix looks obviously correct, especially taking into account the comment to the constructor: * References added to this DGCAckHandler will be held strongly * until its "release" method is invoked or (after the * "startTimer" method has been invoked) the timeout has expired. Would you please help review the fix? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8046339 WEBREV: http://cr.openjdk.java.net/~igerasim/8046339/0/webrev/ Sincerely yours, Ivan

2 2

RFR: 8057826 minor clean-up to the java.sql Date/Time/Timestamp tests
by Lance Andersen 11 Sep '14

11 Sep '14

Hi, Looking for a reviewer for this minor clean-up to the java.sql Date/Time/Timestamp tests which adds support for DataProvider Webrev can be found here: http://cr.openjdk.java.net/~lancea/8057826/webrev.00/ Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com

3 2

RFR: JDK-8056934: ZipInputStream does not correctly handle local header data descriptors with the optional signature missing
by Martin Buchholz 11 Sep '14

11 Sep '14

Hi Xueming and Alan, I'd like you to do a code review. https://bugs.openjdk.java.net/browse/JDK-8056934 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/zip-DataDescriptorSigna… This seems like an atypical off-by-one, so I'm not sure how it happened, and I have the nagging feeling I'm missing something. Greg, this java code review contains a python program!

3 7

XMLScanner-supplementary-characters
by Martin Buchholz 11 Sep '14

11 Sep '14

Hi Huizhe, I have a strange contribution to share. Webrev: http://cr.openjdk.java.net/~martin/webrevs/openjdk9/XMLScanner-supplementar… But I don't have a bug or a test case that I can share and I don't understand the code, except that it's a fix for supporting supplementary characters. Perhaps you can reverse engineer the bug fix to a bug report? Also, maybe this is fixed in "real" xerces? I have no idea... At google we've been carrying this patch around for a while. Martin

3 6

JDK-8057122 also reproduce on Windows Server 2012 r2
by Antoine Mottier 11 Sep '14

11 Sep '14

Hi all, Few days ago I report an issue about os.name value when using jvm.dll on Windows 8.1 ( JDK-8057122). Today I reproduce the same issue on Windows Server 2012 r2. Running the Java class using java.exe will report correct (meaning including r2) os.name version, using the dll, "r2" will not be part of os.name. Source code of a custom launcher that load the dll is already available on the bug report but here is a download link to the full Visual Studio 2013 project: https://www.dropbox.com/s/2fbtili51b7r66a/TestJvm.zip?dl=0 I can do any kind of additional tests if needed, I just have a lack of knowledges about Windows applications building process. Thanks, -- Antoine Mottier

2 2

RFR(S): 8055055: Improve numeric parsing in java.sql
by Claes Redestad 11 Sep '14

11 Sep '14

Hi, can I have a review of this small patch which improves performance of java.sql.Time::valueOf (~1.3x) and java.sql.Timestamp::valueOf (~1.9x). Uses Integer.parseInt with offset to make intermediary substrings unnecessary and improves the nanosecond fraction calculation to not use String concatenation. bug: https://bugs.openjdk.java.net/browse/JDK-8055055 webrev: http://cr.openjdk.java.net/~redestad/8055055/webrev.0/ Thanks! /Claes

2 7