September 2014 - core-libs-dev

Re: RFR [8058099] (ch) Cleanup in FileChannel/FileDispatcher native implementation [win]
by Ivan Gerasimov 17 Sep '14

17 Sep '14

Hello! Is there any interest in this change? It's mostly cleanup, so it is of low priority, but it would be good, if someone could review this. Besides increased readability, this fix makes the code 24 lines shorter and eliminates a compiler warning! :-) Sincerely yours, Ivan On 10.09.2014 14:36, Ivan Gerasimov wrote: > Hello! > > This is a proposal to slightly rework FileChannel/FileDispatcher > native implementation on Windows. > If the newer API is used (which is already available on XP and 2003), > this will make code a bit clear and let us save a few redundant calls. > > Would you please help review the change? > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8058099 > WEBREV: http://cr.openjdk.java.net/~igerasim/8058099/0/webrev/ > > Sincerely yours, > Ivan > >

1 0

RFR JDK-8058204 stream tests timeout, intermittently but more likely to happen after JDK-8056248
by Paul Sandoz 17 Sep '14

17 Sep '14

Hi, Please see below for a patch to disable concurrent execution of the stream tests by jtreg. Due to recent f/j changes some stream tests are now timing out. This is because the tests are running concurrently and parallel stream execution in one process is competing for resources with parallel stream execution in another process. This was actually always the case, but the recent f/j changes appear to be more sensitive to OS scheduling effects on some platforms and there is not much we can do about that at the moment. This is unlikely to increase the overall execution time of the JDK tests by much. Paul. diff -r aabb503ab6de test/TEST.ROOT --- a/test/TEST.ROOT Tue Sep 16 23:16:01 2014 +0200 +++ b/test/TEST.ROOT Tue Sep 16 23:26:11 2014 +0200 @@ -8,7 +8,7 @@ othervm.dirs=java/awt java/beans javax/accessibility javax/imageio javax/sound javax/print javax/management com/sun/awt sun/awt sun/java2d sun/pisces # Tests that cannot run concurrently -exclusiveAccess.dirs=java/rmi/Naming java/util/prefs sun/management/jmxremote sun/tools/jstatd sun/security/mscapi +exclusiveAccess.dirs=java/rmi/Naming java/util/prefs sun/management/jmxremote sun/tools/jstatd sun/security/mscapi java/util/stream # Group definitions groups=TEST.groups [closed/TEST.groups]

3 2

[9] RFR (XS): 8058584: Ignore java/lang/invoke/LFCaching/LFGarbageCollectedTest until 8057020 is fixed
by Vladimir Ivanov 16 Sep '14

16 Sep '14

http://cr.openjdk.java.net/~vlivanov/8058584/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8058584 Exclude java/lang/invoke/LFCaching/LFGarbageCollectedTest from test runs until 8057020 is fixed. Thanks! Best regards, Vladimir Ivanov

3 3

[9] RFR (L): 8057042: LambdaFormEditor: derive new LFs from a base LF
by Vladimir Ivanov 16 Sep '14

16 Sep '14

https://bugs.openjdk.java.net/browse/JDK-8057042 LambdaFormEditor provides an API to transform LambdaForms. Deriving new LambdaForms from a base one allows to cache and reuse results of repeated transformations. BMH binding is rewritten to use LambdaFormEditor. Testing: jdk/java/lang/invoke, jdk/java/util/streams, nashorn, octane w/ "-ea -esa" and COMPILE_THRESHOLD={0,30}. Reviewed-by: vlivanov, ? Contributed-by: john.r.rose(a)oracle.com Thanks! Best regards, Vladimir Ivanov

3 13

[9] RFR (S): 8058293: Bit set computation in MHs.findFirstDupOrDrop/findFirstDrop is broken
by Vladimir Ivanov 16 Sep '14

16 Sep '14

https://bugs.openjdk.java.net/browse/JDK-8058293 http://cr.openjdk.java.net/~vlivanov/8058293/webrev.00 Bit set computation in MHs.findFirstDupOrDrop/findFirstDrop is incorrect due to widening primitive conversions (int -> long) taking place. The fix is to explicitly use long where needed. Also, fixed a case when reorder represents a permutation (zeroPos == newArity). Testing: jck (api/java_lang/invoke), jdk/java/lang/invoke, jdk/java/util/streams w/ "-ea -esa" and COMPILE_THRESHOLD={0,30} Thanks! Best regards, Vladimir Ivanov

2 2

[9] RFR (S): 8058291: Missing some checks during parameter validation
by Vladimir Ivanov 16 Sep '14

16 Sep '14

http://cr.openjdk.java.net/~vlivanov/8058291/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8058291 8057656 & 8050166 changes accidentally removed some checks during argument validation in MHs.dropArguments() and MHs.explicitCastArguments(). The fix is to restore them. Testing: jck (api/java_lang/invoke), jdk/java/lang/invoke, jdk/java/util/streams w/ "-ea -esa" and COMPILE_THRESHOLD={0,30} Thanks! Best regards, Vladimir Ivanov

2 2

Missing clarity in TimerTask doc
by Ulf Zibis 16 Sep '14

16 Sep '14

Hi all, I'm missing clarity, if a j.u.TimerTask object can be scheduled more than once. Especially, can it be scheduled again with Timer.schedule(...) after it has been cancelled, or has a new TimerTask object to be instantiated? What happens if a TimerTask is scheduled again before the first schedule had happened; would it then happen twice or would the same run be re-scheduled? Thanks, -Ulf

2 4

RFR: 8058514: TEST_BUG: New tests introduced in 8058429 are TimeZone dependent
by Claes Redestad 15 Sep '14

15 Sep '14

Hi, please review this simple fix which ensures java.sql.test.sql.TimestampsTests can be run successfully across the globe. Also use a custom timezone ("GMT+01") to make sure the test does not observe DST, which will keep the test running happily all year round. webrev: http://cr.openjdk.java.net/~redestad/8058514/webrev.01/ bug: https://bugs.openjdk.java.net/browse/JDK-8058514 Thanks! /Claes

2 1

RFR: 8058429: JCK test api/java_sql/Timestamp/descriptions.html start failing after 8058230
by Claes Redestad 15 Sep '14

15 Sep '14

Hi, please review this simple fix which addresses a JCK test failure webrev: http://cr.openjdk.java.net/~redestad/8058429/webrev.03 bug: https://bugs.openjdk.java.net/browse/JDK-8058429 /Claes

2 1

RFR: 8058230: Improve java.sql toString formatting
by Claes Redestad 12 Sep '14

12 Sep '14

Hi, requesting reviews for this patch which optimizes java.sql.Date/Time/Timestamp::toString by avoiding some unnecessary object allocations. java.sql.Date had similar optimizations applied which this patch improves upon. bug: https://bugs.openjdk.java.net/browse/JDK-8058230 webrev: http://cr.openjdk.java.net/~redestad/8058230/webrev.00/ Testing: jtreg jdk/test/java/sql with and without 8057826 tests Before/after performance running a minimal JMH micro[1]: Benchmark Mode Samples Score Score error Units t.DateBench.dateToString thrpt 20 30225.628 623.887 ops/ms t.DateBench.dateToString thrpt 20 38350.173 1349.432 ops/ms # 1.3x t.DateBench.timeToString thrpt 20 11793.338 232.121 ops/ms t.DateBench.timeToString thrpt 20 47048.344 1969.939 ops/ms # 4.0x t.DateBench.timestampToString thrpt 20 2529.601 45.990 ops/ms t.DateBench.timestampToString thrpt 20 14143.612 407.351 ops/ms # 5.6x /Claes [1] package test; import org.openjdk.jmh.annotations.*; @State(Scope.Thread) public class DateBench { public java.sql.Time time = java.sql.Time.valueOf("15:15:25"); @Benchmark public String timeToString() { return time.toString(); } public java.sql.Date date = java.sql.Date.valueOf("2013-01-01"); @Benchmark public String dateToString() { return date.toString(); } public Timestamp timestamp = Timestamp.valueOf("1999-12-13 15:15:25.645634"); @Benchmark public String timestampToString() { return timestamp.toString(); } }

5 4