September 2014 - core-libs-dev

JEP 187: Serialization 2.0
by mark.reinhold＠oracle.com 30 Dec '14

30 Dec '14

Posted: http://openjdk.java.net/jeps/187 - Mark

5 8

Covariant overrides on the Buffer Hierarchy redux
by Paul Sandoz 29 Oct '14

29 Oct '14

Hi, There was discussion here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-April/026458.html https://bugs.openjdk.java.net/browse/JDK-4774077 http://cr.openjdk.java.net/~rwarburton/buffer-overrides-1/ The patch looks good. I have just one comment: can you check the tests to see if there are any redundant casts? After that i will run a JPRT test and then will push for you. Thanks, Paul.

4 7

FilterOutputStream.close() throws exception from flush()
by Bernd Eckenfels 20 Oct '14

20 Oct '14

Hello, back in 2011 there was a discussion about the new changed behavior of FilterOutputStream (and BufferedOutputStream) in regards to not anymore swalloging IOExceptions from flush() on this list (thats where I got the subject from). This was generally a very good improvement (and I am glad that https://bugs.openjdk.java.net/browse/JDK-6335274 thereby got fixed). However the implementation with the try-with-resource has a problem: when flush() and close() report the same exception instance the construction of the suppressed exception will actually fail with an IllegalArgumentException. This IllegalArgumentException of Throwable.addSuppressed is very unfortunate (it would be better simply ignore it). Anyway, this new behavior broke a Unit-Test for Apache VFS as you can see here: https://issues.apache.org/jira/browse/VFS-521 I think this can only be fixed in Throwable by avoiding this IllegalArgumentException or by the close() method not using try-with-resource. For reference, according to this changeset other locations are affected as well: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/759aa847dcaf Gruss Bernd PS: I wrote a german blogpost about the FilterOutputStream here: http://itblog.eckenfels.net/archives/505-FOS-considered-harmfull.html The following exception is produced by the testcode: Exception in thread "main" java.lang.IllegalArgumentException: Self-suppression not permitted at java.lang.Throwable.addSuppressed(Throwable.java:1043) at java.io.FilterOutputStream.close(FilterOutputStream.java:159) at testfos.Main.main(Main.java:6) Caused by: java.io.IOException: remebered IO Exception at testfos.FailingOS.<init>(FailingOS.java:10) at testfos.Main.main(Main.java:5) package testfos; public class Main { public static void main(String[] args) throws java.io.IOException { java.io.BufferedOutputStream buf = new java.io.BufferedOutputStream(new testfos.FailingOS()); buf.close(); // expected: IOException } } package testfos; public class FailingOS extends java.io.OutputStream { private java.io.IOException ex; public FailingOS() { ex = new java.io.IOException("remebered IO Exception"); } public void write(int b) throws java.io.IOException { } public void flush() throws java.io.IOException { throw ex; } public void close() throws java.io.IOException { throw ex; } }

4 5

Review request for JDK-8051561: Convert JAXP function tests: javax.xml.xpath.* to jtreg (testNG) tests
by Eric Wang 15 Oct '14

15 Oct '14

Hi Joe, alan and every one I'm working on jaxp functional test colocation which is traced by the bug JDK-8043091 <https://bugs.openjdk.java.net/browse/JDK-8043091>. We have finished to convert a few suite and the jaxp/xpath tracked by bug JDK-8051561 <https://bugs.openjdk.java.net/browse/JDK-8051561> is the first one chosen for public review. Can you please review the webrev below? your comments given would be helpful for our future work. http://cr.openjdk.java.net/~ewang/JDK-8051561/webrev.00/ Thanks, Eric

8 24

RFR JDK-8044627: Update JNDI to work with modules
by Pavel Rappo 14 Oct '14

14 Oct '14

Hi everyone, Could you please review my change for JDK-8044627? http://cr.openjdk.java.net/~prappo/8044627/webrev.00/ -Pavel

3 7

java.util.logging.FileHandler integer overflow prevents file rotation
by Stanimir Simeonoff 06 Oct '14

06 Oct '14

java.util.logging.FileHandler uses ints to track the written bytes that can cause negative value for java.util.logging.FileHandler.MeteredStream.written as there is no check in any of the write methods. The overflow prevents the check in FileHandler.publish(LogRecord) meter.written >= limit to ever trigger, esp. setting limit to Integer.MAX_VALUE that effectively always prevents file rotation. On a flip note, MeteredStream should be a static class. On another flip note, FileHandler should be using long as part of the API and internal implementation. ints are limited to 2GiB even when properly implemented that's a relatively low amount for certain types of logging files. So I propose adding overloaded c-tors FileHandler(String pattern, long limit, int count, boolean append) and FileHandler(String pattern, long limit, int count). LogManager should have a method "long getLongProperty(String name, long defaultValue)" to initialize limit. Thanks Stanimir

3 2

JEP 198: Light-Weight JSON API
by mark.reinhold＠oracle.com 01 Oct '14

01 Oct '14

New JEP Candidate: http://openjdk.java.net/jeps/198 - Mark

5 4

[9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity >253 can't be cached
by Konstantin Shefov 01 Oct '14

01 Oct '14

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058695 Webrev is http://cr.openjdk.java.net/~kshefov/8058695/webrev.00/ There is also a fix to https://bugs.openjdk.java.net/browse/JDK-8058733 in this diff. Thanks -Konstantin

2 2

8025690: Default FileHandler constructor doesn't throw NullPointerException if pattern is empty and count > 1
by Daniel Fuchs 01 Oct '14

01 Oct '14

Hi, Please find below a fix for 8025690: Default FileHandler constructor doesn't throw NullPointerException if pattern is empty and count > 1 https://bugs.openjdk.java.net/browse/JDK-8025690 The default constructor of FileHandler is specified to throw a NullPointerException if the pattern property string is an empty string. (see <http://docs.oracle.com/javase/8/docs/api/java/util/logging/FileHandler.html…>) However it strangely does so only when count=1 The fix adds an additional check in openFiles() to verify that the pattern is not empty. At this point the other constructors (which take a pattern as parameter) will already have thrown an IAE if the pattern was empty (or an NPE if it was null). http://cr.openjdk.java.net/~dfuchs/webrev_8025690/webrev.00 best regards, -- daniel

3 5

RFR: 8059411, RowSetWarning does not chain warnings
by Lance Andersen 29 Sep '14

29 Sep '14

Hi all, Need a reviewer for 8059411 which is a simple fix & test for the fact RowSetWarning does not properly chain warnings. With the fix, the JCK still passes. The webrev can be found at http://cr.openjdk.java.net/~lancea/8059411/webrev.00/ Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com

3 5