RFR 8061253: CCC 8043071 doesn't fully approve the change in JDK9b25

Jamil Nimeh jamil.j.nimeh at oracle.com
Tue Nov 18 09:54:41 UTC 2014


Hi Max, I only have very nit-picky comments/questions, actually the same 
question across 4 files.

  * KerberosKey.java
      o 298 and 305: Should the "KerberosKey" words be inside @code braces?
  * KerberosPrincipal.java
      o 195: Same @code question as above with "Principal"
  * KerberosTicket.java
      o 722 and 729: Same @code question for "KerberosTicket"
  * KeyTab.java
      o 341 and 347: ditto, but for "KeyTab"

--Jamil


On 11/17/2014 11:47 PM, Wang Weijun wrote:
> Re-request for code review at
>
>    http://cr.openjdk.java.net/~weijun/8061253/webrev.01/
>
> Most are still spec changes, with only one code change in KerberosTicket.java where KerberosPrincipal.toString() is changed to KerberosPrincipal.getName(). This is also because the spec for getName() is more suitable in this call.
>
> *Jamil*: I usually don't touch copyright years and let RE handle it. You might say this is not a good habit.
>
> Thanks
> Max
>
>> On Nov 15, 2014, at 08:05, Wang Weijun <weijun.wang at oracle.com> wrote:
>>
>> Webrev withdrawn. I'd like to make more changes.
>>
>> Thanks
>> Max
>>
>>> On Nov 14, 2014, at 10:38, Wang Weijun <weijun.wang at oracle.com> wrote:
>>>
>>> Hi All
>>>
>>> This is a doc change only bug. Fix at
>>>
>>>   http://cr.openjdk.java.net/~weijun/8061253/webrev.00/
>>>
>>> Please take a review.
>>>
>>> Thanks
>>> Max
>>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/security-dev/attachments/20141118/7db6db6d/attachment.html>


More information about the security-dev mailing list