RFR 8212217: JGSS: Don't dispose() of creds too eagerly

Sean Mullan sean.mullan at oracle.com
Tue Oct 30 14:28:40 UTC 2018


I think you should put braces around the conditional statements on lines 
332, 357, & 359. It would read better and avoid accidental bugs.

Where does delegatedCred get used? It seems to be never set.

Otherwise looks fine. You will need to add a noreg label if you can't 
write a test.

--Sean

On 10/15/18 9:43 PM, Weijun Wang wrote:
> Please take a review at
> 
>     http://cr.openjdk.java.net/~weijun/8212217/webrev.00/
> 
> This bug is reported and fixed by Nico Williams <nico at twosigma.com>.
> 
> I'll think if a regression test can be added.
> 
> Thanks
> Max
> 



More information about the security-dev mailing list