RFR 8212217: JGSS: Don't dispose() of creds too eagerly

Weijun Wang weijun.wang at oracle.com
Wed Oct 31 09:22:27 UTC 2018


Copying Nico the original author.


> On Oct 30, 2018, at 10:28 PM, Sean Mullan <sean.mullan at oracle.com> wrote:
> 
> I think you should put braces around the conditional statements on lines 332, 357, & 359. It would read better and avoid accidental bugs.
> 
> Where does delegatedCred get used? It seems to be never set.

It's set in a native method

 322             outToken = cStub.acceptContext(pCred, cb, inToken, this);

> 
> Otherwise looks fine. You will need to add a noreg label if you can't write a test.

Yes.

Thanks
Max

> 
> --Sean
> 
> On 10/15/18 9:43 PM, Weijun Wang wrote:
>> Please take a review at
>>    http://cr.openjdk.java.net/~weijun/8212217/webrev.00/
>> This bug is reported and fixed by Nico Williams <nico at twosigma.com>.
>> I'll think if a regression test can be added.
>> Thanks
>> Max




More information about the security-dev mailing list