RFR [17]: JDK-8260310 Release Note: Configurable extensions with system properties
Xue-Lei Fan
xuelei.fan at oracle.com
Sat Jan 30 00:52:23 UTC 2021
Hi Jamil,
All good catches! Thanks for the review. I updated accordingly.
Xuelei
On Jan 29, 2021, at 4:41 PM, Jamil Nimeh <jamil.j.nimeh at oracle.com<mailto:jamil.j.nimeh at oracle.com>> wrote:
Hi Xuelei, looks good overall, some minor suggestions only:
* 1st paragraph: Change "...block extensions used in client side" and "...used to block extensions used in server side" to say "...used in the client." and "...used in the server." (you can remove the "side" words).
* 1st paragraph: if you use "neither" then you should follow it with "nor" rather than "or"
* The 3rd paragraph's leading sentence is a fragment. You might be able to remove that sentence entirely without changing the meaning behind the paragraph. With that first sentence removed and the "But" from the next sentence also omitted I think it reads a little more smoothly, at least to my eyes.
* I'm not sure if we have any style guide rules concerning contractions in release notes, but I think changing "don't" -> "do not" also reads better for these kinds of things.
--Jamil
On 1/29/2021 4:23 PM, Xue-Lei Fan wrote:
Hi,
May I have the following release note reviewed:
https://bugs.openjdk.java.net/browse/JDK-8260310
Thanks,
Xuelei
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20210130/a35a77a7/attachment.htm>
More information about the security-dev
mailing list