Integrated: 8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java

Aleksey Shipilev shade at openjdk.java.net
Thu Jun 24 06:39:33 UTC 2021


On Wed, 23 Jun 2021 07:38:37 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> SonarCloud reports:
> "Remove or correct this useless self-assignment."
> 
> 
>         if (cipherAlgo.equals("AES")) {
>             this.keysize = keysize; // <---- here
>             switch (keysize) {
>             case 128:
>                 cipherAlgo_OID = aes128CBC_OID;
> 
> 
> Seems to be here since initial addition in JDK-6383200.
> 
> Additional testing:
>  - [x] `jdk_security` pass

This pull request has now been integrated.

Changeset: e515873f
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/e515873f887ce4071ab4878a4bafca8eea67afea
Stats:     1 line in 1 file changed: 0 ins; 1 del; 0 mod

8269216: Useless initialization in com/sun/crypto/provider/PBES2Parameters.java

Reviewed-by: valeriep

-------------

PR: https://git.openjdk.java.net/jdk/pull/4570



More information about the security-dev mailing list